Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSD Returns #379

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

LSD Returns #379

wants to merge 28 commits into from

Conversation

KoishiVibe
Copy link
Contributor

Summary

  • Mindbreaker is removed.
  • LSD comes back for REAL roleplayers.
  • LSD is now under name diethylamide.

@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

KoishiVibe and others added 2 commits August 20, 2024 20:49
unfucks stupid weird commit thing arfgh argh argh
thanks dmc

Co-authored-by: Doubleumc <[email protected]>
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the reagent as per the previous review:

Prefer for this to be typed as /datum/reagent/toxin/lsd or similar. People understand what LSD means. Diethylamide is much less clear what it does.

Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more what I had in mind by changing its identifier to lsd.

Otherwise, code good.

@@ -450,7 +450,7 @@
/obj/item/reagent_container/syringe/drugs/Initialize()
. = ..()
reagents.add_reagent("space_drugs", 5)
reagents.add_reagent("mindbreaker", 5)
reagents.add_reagent("diethylamide", 5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reagents.add_reagent("diethylamide", 5)
reagents.add_reagent("lsd", 5)

@@ -245,7 +245,7 @@ var/global/list/gene_tag_masks = list() // Gene obfuscation for delicious tria
"rezadone",
"ethylredoxrazine",
"cyanide",
"mindbreaker",
"diethylamide",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"diethylamide",
"lsd",

rarity = PROPERTY_COMMON
category = PROPERTY_TYPE_STIMULANT
value = 1

/datum/chem_property/neutral/antihallucinogenic/process(mob/living/M, potency = 1)
M.reagents.remove_reagent("mindbreaker", 5)
M.reagents.remove_reagent("diethylamide", 5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
M.reagents.remove_reagent("diethylamide", 5)
M.reagents.remove_reagent("lsd", 5)

@@ -192,19 +192,19 @@
name = "Methylphenidate"
id = "methylphenidate"
result = "methylphenidate"
required_reagents = list("mindbreaker" = 1, "hydrogen" = 1)
required_reagents = list("diethylamide" = 1, "hydrogen" = 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required_reagents = list("diethylamide" = 1, "hydrogen" = 1)
required_reagents = list("lsd" = 1, "hydrogen" = 1)

result_amount = 3

/datum/chemical_reaction/citalopram
name = "Citalopram"
id = "citalopram"
result = "citalopram"
required_reagents = list("mindbreaker" = 1, "carbon" = 1)
required_reagents = list("diethylamide" = 1, "carbon" = 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required_reagents = list("diethylamide" = 1, "carbon" = 1)
required_reagents = list("lsd" = 1, "carbon" = 1)

result_amount = 3

/datum/chemical_reaction/paroxetine
name = "Paroxetine"
id = "paroxetine"
result = "paroxetine"
required_reagents = list("mindbreaker" = 1, "oxygen" = 1, "inaprovaline" = 1)
required_reagents = list("diethylamide" = 1, "oxygen" = 1, "inaprovaline" = 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required_reagents = list("diethylamide" = 1, "oxygen" = 1, "inaprovaline" = 1)
required_reagents = list("lsd" = 1, "oxygen" = 1, "inaprovaline" = 1)

Comment on lines +293 to +296
/datum/chemical_reaction/diethylamide
name = "Lysergic Acid Diethylamide"
id = "diethylamide"
result = "diethylamide"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/datum/chemical_reaction/diethylamide
name = "Lysergic Acid Diethylamide"
id = "diethylamide"
result = "diethylamide"
/datum/chemical_reaction/lsd
name = "Lysergic Acid Diethylamide"
id = "lsd"
result = "lsd"

description = "A powerful hallucinogenic compound that is illegal under space law. Causes extreme hallucinations and is very addictive. Formerly known as LSD."
/datum/reagent/toxin/lsd
name = "lysergic acid diethylamide"
id = "diethylamide"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id = "diethylamide"
id = "lsd"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants