[TM Ready] Chemical Weapons (CN20) in the FS Menu #510
+110
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…then onto the actual FS menu
…rks until OB's are in the actual FS menu so whoopsies lmao
…simply, add both to the FS menu! I shall test it :clueless:
…ince that's only defined in DS_ammo
…creations I have brought into this game
GriffinMan4455
changed the title
Doubleumc
requested changes
Oct 23, 2024
| #define ORDNANCE_OPTIONS list("Banshee Missile", "CN-20 Missile", "Harpoon Missile", "Keeper Missile", "Napalm Missile", "Thermobaric Missile", "Widowmaker Missile", "Laser", "Minirocket", "Incendiary Minirocket", "Sentry Drop", "GAU-21", "Heavy GAU-21", "High Explosive", "Incendiary", "Cluster", "High Explosive", "Incendiary", "Fragmentation", "Flare") | ||
| #define MISSILE_ORDNANCE list("Banshee Missile", "CN-20 Missile", "Harpoon Missile", "Keeper Missile", "Napalm Missile", "Thermobaric Missile", "Widowmaker Missile") | ||
| #define ORBITAL_ORDNANCE list("High Explosive OB", "Incendiary OB", "Cluster OB", "Nerve Gas OB") | ||
| #define MORTAR_ORDNANCE list("High Explosive Shell", "Incendiary Shell", "Fragmentation Shell", "Flare Shell", "Nerve Gas Shell") |
There was a problem hiding this comment.
You add a "Nerve Gas Shell" to the options, but do not specify what that option will do within the InterceptClickOn proc. Need to specify it as you did with "CN-20 Missile" and "Nerve Gas OB".
There was a problem hiding this comment.
Oh! I was working on these a couple days ago, I just completely forgot to finish them up, my bad lmao
I think I set the actual mortar shell coding aside when someone, Amory maybe, suggested seperating the chemical weapons to a new menu subpart entirely and I started looking into how to do so w/ the TGUI
code/modules/admin/game_master/extra_buttons/fire_support_menu.dm
Outdated
Show resolved
Hide resolved
Ah, yup that'd be because I stole most of the code for each of these from a respective fire support item (This one's from the banshee I'm pretty sure). I don't remember any secondary explosions from my tests which is weird, though. Co-authored-by: Doubleumc <[email protected]>
Aaaah, I see. Thanks for the help UMC! Co-authored-by: Doubleumc <[email protected]>
I actually did space out a couple of things after seeing it formatted that way on other PR's, I must've just missed this one Co-authored-by: Doubleumc <[email protected]>
Co-authored-by: Doubleumc <[email protected]>
Co-authored-by: Doubleumc <[email protected]>
…k up my accidental merge conflict I just made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR Contains working CN20 Gas variants for:
Mortar Shells
Dropship Missiles (Banshee variant)
OB (Fuckhueg cloud)
All tested, all work fine.
Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. -->
Explain why it's good for the game
GM's always want more fire support stuff, and CN20 has been mentioned by name several times now especially in chemical weapons ops, since using it without spawning a person and having them chuck nades can be difficult
Testing Photographs and Procedure
I'll add some after everything's in maybe (I said this for all my other PR's and half of them I forgot lmao)
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: CN20 rounds for: Dropship, Mortar, OB
qol: FS Menu contains CN20 rounds for Dropship, Mortar, OB
ui: FS UI, dunno if I have to mention this here though
/:cl: