Upstream/tg Status effects port - part 1 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@morrowwolf We could test this merge or just merge it outright. I don't believe there were any issues with this on main. |
|
Definitely want a testmerge in case it messes with the AI in some form. |
|
Eeeh brief tests seem fine we'll manage any fallout as necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports cmss13-devs/cmss13#4828
Essentially deletes
update_canmove()by making updates dynamic using trait signals, porting status traits,body_positionandmobility_flagsto make it happen.Only done summary testing, it needs a proper look over with AI systems.
Can either tack on part 2 and 3A on top of it or do it separately. Either way it'd need intermediate testing.