Pill bottle emptying bugfix #7357
Open
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes an annoying bug introduced in #7265 which caused pill bottles to run through two simultaneous emptying processes whenever used in the hand. First trying to empty their contents, then moving to their own pill drawing code, and trying to draw a single pill from the empty bottle.
This PR bypasses the typical emptying system, for pill bottles and packets, allowing a single pill to be drawn from a pill bottle in hand with Z, but still leaves the empty verb functional, so bottles can be emptied by selecting the option after right clicking.
Explain why it's good for the game
While I recognize I am in the vast minority, some HM players still prefer not to use the belt system of drawing directly from pill bottles when treating patients.
Drawing a pill from a pill bottle held in the hand allows HMs to keep track of which medications have been given, and in what order.
#7265 broke this system by forcing HMs to start emptying pill bottles in the hand on a click, rather than drawing a single pill, making it exceptionally annoying to medicate wounded without belt mode, and near impossible to do so without a belt.
This PR allows both systems to co-exist, letting HMs draw a single pill from bottles held in the hand if they choose to do so, and still leaving the empty verb on pill bottles, so that their contents can be dumped through the right click menu
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: no longer forces pill bottles to begin emptying on a click
/:cl: