Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blogpost by Junxing Wang #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Blogpost by Junxing Wang #3

wants to merge 1 commit into from

Conversation

thuwjx
Copy link

@thuwjx thuwjx commented Dec 3, 2021

No description provided.

@jaybosamiya
Copy link
Collaborator

Hi Junxing Wang,

Given that this is the first blogpost going onto the website, we've recognized some improvements we could make to the process to prevent issues that have cropped up. I've recently made changes to the templates and improved the instructions in the necessary locations to account for these and add a few automated checks too. However, this does mean you need to make a few updates before your blogpost can be accepted and published. Please find necessary instructions below.

Update to merge the latest version of the main repository onto your code:

git remote add upstream [email protected]:cmu-csd-phd/csd-blog.git
git fetch upstream
git merge upstream/main
git merge upstream/main --no-edit

Move all the images into the correct directory and automatically update the blogpost page to utilize the correct paths:

mkdir -p website/static/2021/min-degree/
mv website/content/2021/eq*.png website/static/2021/min-degree/
sed -i 's|../eq|./eq|' website/content/2021/min-degree.md

Make a new commit:

git add .
git commit -m 'Move images into the correct folder'

Run the ./local_server.sh script to check that things look good. Here, you'll notice that warnings show up on the page, since you hadn't followed the instructions for what "areas" must be mentioned in the blogpost as per the template.md file. Please make the necessary changes to fix this, and test again and commit.

Also, if you look at the alt-tags that you've given to the different equations (i.e., the part within the [] as part of the ![..](..) tag for images), that alt-tags are not really helpful towards folks who might be visually-impaired. Please fix these to better descriptions, for example, the first image can have the alt-tag as "three linear equations, x1 + x2 = 3; x1 + x2 + x3 = 6; and x2 + x3 = 5" or similar. Fix this for all the images that you have in the document, and test again and commit.

Make all the changes required as per @JennLCSD's instructions above. Test again and commit.

Once everything looks good, please push all your changes so that they can be looked at to confirm that everything looks good.

Please let me know if you have any questions. Thanks!

@jaybosamiya
Copy link
Collaborator

Also, please make sure to let @JennLCSD know once you've made the necessary changes and pushed them, so that she can review things and do the necessary next steps. Thanks!

# For example:
# author = "Harry Bovik"
# However, adding a URL is strongly preferred
author = {name = "Junxing Wang", url = "junxingwang.org" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I just noticed that clicking on your name does not go to your website as expected, since you have not specified your full URL. Please fix it:

Suggested change
author = {name = "Junxing Wang", url = "junxingwang.org" }
author = {name = "Junxing Wang", url = "https://junxingwang.org/" }

@drbarrett
Copy link
Collaborator

The author is long gone and didn't respond to repeated requests to fix this post so I'm closing it.

@drbarrett drbarrett closed this Apr 11, 2024
@thuwjx
Copy link
Author

thuwjx commented Apr 12, 2024 via email

@drbarrett drbarrett reopened this May 17, 2024
@drbarrett
Copy link
Collaborator

Reopened the PR.

@drbarrett
Copy link
Collaborator

Please make the changes mentioned by Jay so that we can merge this into the blog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants