Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted itsdangerous from requirements as no needed #1131

Merged
merged 2 commits into from
Oct 11, 2023
Merged

deleted itsdangerous from requirements as no needed #1131

merged 2 commits into from
Oct 11, 2023

Conversation

BrainIsDead
Copy link
Contributor

@BrainIsDead BrainIsDead commented Apr 11, 2023

closes #848

Summary:

Actually, Flask version is 2.2.2, just deleted itsdangerous from requirements as not needed

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@krivard
Copy link
Contributor

krivard commented Apr 11, 2023

@dshemetov @melange396 looks like the Flask 2.2 upgrade was merged in #1043 and released in v0.4.4 back in December; was that intentional?

@dshemetov
Copy link
Contributor

Huh, definitely not. That PR actually just sorted the dependencies, but didn't upgrade. Here is the commit that upgraded us back in September 2022.

@krivard
Copy link
Contributor

krivard commented Apr 11, 2023

that's substantially less suspicious as it was part of the initial 0.4.0 release, but still feels odd not to have marked it at the time

@dshemetov
Copy link
Contributor

dshemetov commented Apr 11, 2023

Yup, well, either it was intentional and undocumented or unintentional and lucky. Either way, looks like we've been on Flask 2.2 since September without visible issues 🍀🚀

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melange396 melange396 merged commit d4e4175 into dev Oct 11, 2023
@melange396 melange396 deleted the #848 branch October 11, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Flask to 2.0.0
4 participants