-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deleted itsdangerous from requirements as no needed #1131
Conversation
Kudos, SonarCloud Quality Gate passed! |
@dshemetov @melange396 looks like the Flask 2.2 upgrade was merged in #1043 and released in v0.4.4 back in December; was that intentional? |
Huh, definitely not. That PR actually just sorted the dependencies, but didn't upgrade. Here is the commit that upgraded us back in September 2022. |
that's substantially less suspicious as it was part of the initial 0.4.0 release, but still feels odd not to have marked it at the time |
Yup, well, either it was intentional and undocumented or unintentional and lucky. Either way, looks like we've been on Flask 2.2 since September without visible issues 🍀🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
closes #848
Summary:
Actually, Flask version is 2.2.2, just deleted itsdangerous from requirements as not needed
Prerequisites:
dev
branchdev