Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated broken link to CDC epiweek #1416

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Updated broken link to CDC epiweek #1416

merged 1 commit into from
Apr 11, 2024

Conversation

tinatownes
Copy link
Collaborator

@tinatownes tinatownes commented Apr 11, 2024 •
edited by nmdefries
Loading

Updated broken link to CDC epiweek and checked changes on locally built site.

Summary:

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@tinatownes
Updated broken link to CDC epiweek
cdda8b8 
Updated broken link to CDC epiweek and checked changes on locally built site.
@tinatownes tinatownes requested a review from nmdefries April 11, 2024 01:04
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

nmdefries
nmdefries approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

thought: For this particular link, since it's a PDF, we could also download it, add it to the repo directly, and make a local link. That's a future change, though.

@nmdefries nmdefries merged commit c8c4830 into dev Apr 11, 2024
7 checks passed
@nmdefries nmdefries deleted the ttownes/NCHSmortality_edits branch April 11, 2024 21:50
@melange396 melange396 mentioned this pull request May 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmdefries nmdefries nmdefries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinatownes @nmdefries