Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NHSN doc changes #1601

Merged
merged 7 commits into from
Feb 25, 2025
Merged

NHSN doc changes #1601

merged 7 commits into from
Feb 25, 2025

Conversation

aysim319
Copy link
Contributor

@aysim319 aysim319 commented Feb 19, 2025

addresses issue(s) #2125

Summary:

doc changes for NHSN

8 new NHSN signals were added by 2 PRs:

(both PRs were released to production as part of cmu-delphi/covidcast-indicators#2126 )

They consist of the 4 listed at https://github.com/cmu-delphi/covidcast-indicators/blob/454ac565d0a0f2b5cf557e4efb2278c278c528a9/nhsn/delphi_nhsn/constants.py#L18-L21 as well as the associated "_prelim" versions of each.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@aysim319 aysim319 changed the title inital commit NHSN doc changes Feb 19, 2025
nmdefries
nmdefries previously approved these changes Feb 19, 2025
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the wording changes I made. After those are included, this is good to go.

@aysim319
Copy link
Contributor Author

@carlynvandyke thanks for catching my numerous copy pastas 😅 hopefully i fixed it this time around

@aysim319 aysim319 requested a review from melange396 February 24, 2025 16:26
melange396
melange396 previously approved these changes Feb 24, 2025
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could fix some of the spacing to make the table line up better in the raw file, but it doesnt affect the rendered version. otherwise, it looks good to me!

@aysim319 aysim319 merged commit f450e7a into dev Feb 25, 2025
8 checks passed
@aysim319 aysim319 deleted the 2125-update-nhsn-docs branch February 25, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants