Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate missing content from default language during build #612

Merged
merged 23 commits into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
9cb7cde
remove unused about page
lianmakesthings Apr 5, 2024
907181b
remove untranslated pages from chinese page
lianmakesthings Apr 5, 2024
853e048
add script to duplicate content from english if missing in language
lianmakesthings Apr 5, 2024
66094a5
remove duplicated content from korean page
lianmakesthings Apr 5, 2024
48aa81b
remove duplicated content from japanese page
lianmakesthings Apr 5, 2024
19a5c14
remove duplicated content from spanish page
lianmakesthings Apr 5, 2024
8beb212
remove duplicated content from french page
lianmakesthings Apr 5, 2024
4e7dc8c
duplicate english content if localised version does not exist
lianmakesthings Apr 5, 2024
78904bb
remove unnecessary gh action
lianmakesthings Apr 5, 2024
58689d2
remove requirement to copy all content to new languages
lianmakesthings Apr 5, 2024
a780948
change wording to better communicate intent
lianmakesthings Apr 5, 2024
209d827
Revert "remove unnecessary gh action"
lianmakesthings Apr 6, 2024
807b6b6
change wording in gh action to reflect new process
lianmakesthings Apr 6, 2024
ae80471
fix formatting in translation issue template
lianmakesthings Apr 8, 2024
eebaaa1
Update .github/ISSUE_TEMPLATE/translation.yml
Apr 13, 2024
869e03b
update meeting time on website and in readme
lianmakesthings Apr 4, 2024
bfe8a3f
spanish translation
lianmakesthings Apr 4, 2024
0980130
chinese translation
lianmakesthings Apr 4, 2024
35efd19
korean translation
lianmakesthings Apr 4, 2024
fd43eea
japanese translation
lianmakesthings Apr 4, 2024
b9f691e
Remove word-wrapping within paragraphs
cjyabraham Apr 13, 2024
99e168a
remove duplicated english content
lianmakesthings Apr 15, 2024
a38e546
Merge branch 'main' into improve-language-support
lianmakesthings Apr 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/translation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,8 @@ body:
value: |
If this is a new translation, please complete the following items:
- [ ] Enable i18n by update website/config.toml and website/i18n/<short-language-code>.toml
- [ ] Copy all contents to content/<short-language-code>

All translations require the following items:
- [ ] Translate some key pages (e.g. content/<short-language-code>/_index.md)
- [ ] Translate some key pages (e.g. content/_short-language-code_/_index.md)
- [ ] Local testing
- [ ] Reviews by additional native speakers
6 changes: 2 additions & 4 deletions .github/workflows/notice-i18n-tasks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,5 @@ jobs:
message: |
### Action Required
You are adding or updating English content so please take the following actions for other languages.
- If you add new content under `website/content/en` or targets of the symbolic links in the same directory, please replicate it in the corresponding directories of all other languages. (e.g. If you create `website/content/en/blog/new-post.md`, you should copy it to `website/content/ja/blog/new-post.md`, etc.)
- If you update the content in the same location, please perform the following actions for the corresponding content in other languages.
- If the content has not been translated yet, replace the files with the updated English version.
- If the content has already been translated, include a note suggesting that users check the English page for the most recent updates.
- If you update content, that has corresponding files in other languages, include a note suggesting that users check the English page for the most recent updates in those translated pages.
- If you add new content under `website/content/en` there is nothing you need to do.
Comment on lines +39 to +40
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 This will be a much better experience! I have added a comment to #615 to possibly even improve on this even more 💪

2 changes: 2 additions & 0 deletions website/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,14 @@ serve:

production-build:
git submodule update --init --recursive
./duplicate_missing_content.sh
hugo \
--minify
npx -y pagefind --site public

preview-build:
git submodule update --init --recursive
./duplicate_missing_content.sh
hugo \
--baseURL $(DEPLOY_PRIME_URL) \
--buildDrafts \
Expand Down
19 changes: 0 additions & 19 deletions website/content/en/about/_index.md

This file was deleted.

24 changes: 0 additions & 24 deletions website/content/en/about/wg-platforms.md

This file was deleted.

2 changes: 1 addition & 1 deletion website/content/es/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Today there are two active working groups under the TAG -

## Meetings

Every two weeks on Wednesday at 16:00 UTC ([convert to your local
1st and 3rd Wednesday of each month at 16:00 UTC ([convert to your local
time](https://dateful.com/convert/utc?t=16)).

Meetings are listed on the [main CNCF calendar](https://www.cncf.io/calendar/)
Expand Down
19 changes: 0 additions & 19 deletions website/content/es/about/_index.md

This file was deleted.

24 changes: 0 additions & 24 deletions website/content/es/about/wg-platforms.md

This file was deleted.

72 changes: 0 additions & 72 deletions website/content/es/blog/2023-10-kubecon-chicago.md

This file was deleted.

This file was deleted.

6 changes: 0 additions & 6 deletions website/content/es/blog/_index.md

This file was deleted.

87 changes: 0 additions & 87 deletions website/content/es/blog/announce-platforms-paper.md

This file was deleted.

Loading