Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Infrastructure Lifecycle WG website content #751

Merged
merged 13 commits into from
Oct 8, 2024

Conversation

bschaatsbergen
Copy link
Contributor

  • Adds home page of the Infrastructure Lifecycle WG
  • Copied over our charter
  • Contains the start of our glossary

Copy link

Action Required

You are adding or updating English content so please take the following actions for other languages.

  • If you update content, that has corresponding files in other languages, include a note suggesting that users check the English page for the most recent updates in those translated pages.
  • If you add new content under website/content/en there is nothing you need to do.

Copy link

netlify bot commented Sep 14, 2024

Deploy Preview for tag-app-delivery ready!

Name Link
🔨 Latest commit 72f69ae
🔍 Latest deploy log https://app.netlify.com/sites/tag-app-delivery/deploys/66fffb6efc3c1c0008e8f094
😎 Deploy Preview https://deploy-preview-751--tag-app-delivery.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bschaatsbergen
Copy link
Contributor Author

bschaatsbergen commented Sep 14, 2024

Is it expected that the netlify preview deployment does not render the newly added Infrastructure Lifecycle pages?

@abangser
Copy link
Collaborator

Is it expected that the netlify preview deployment does not render the newly added Infrastructure Lifecycle pages?

No, that is definitely showing an issue. But the issue isn't your pages, it is the surfacing of your pages. You can go directly to the URLs like this: https://deploy-preview-751--tag-app-delivery.netlify.app/wgs/infra-lifecycle/

So what you need to add in is the addition of this WG to the different lists etc where the others are.

Signed-off-by: Bruno Schaatsbergen <[email protected]>
Signed-off-by: Bruno Schaatsbergen <[email protected]>
Signed-off-by: Bruno Schaatsbergen <[email protected]>
Signed-off-by: Bruno Schaatsbergen <[email protected]>
Signed-off-by: Bruno Schaatsbergen <[email protected]>
Signed-off-by: Bruno Schaatsbergen <[email protected]>
Signed-off-by: Bruno Schaatsbergen <[email protected]>
@bschaatsbergen
Copy link
Contributor Author

Is it expected that the netlify preview deployment does not render the newly added Infrastructure Lifecycle pages?

No, that is definitely showing an issue. But the issue isn't your pages, it is the surfacing of your pages. You can go directly to the URLs like this: https://deploy-preview-751--tag-app-delivery.netlify.app/wgs/infra-lifecycle/

So what you need to add in is the addition of this WG to the different lists etc where the others are.

Fixed @abangser! :)

Signed-off-by: Bruno Schaatsbergen <[email protected]>
Signed-off-by: Bruno Schaatsbergen <[email protected]>
Co-authored-by: Jochen Zehnder <[email protected]>
Signed-off-by: Bruno Schaatsbergen <[email protected]>
Copy link

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abangser
abangser previously approved these changes Sep 26, 2024
Copy link
Collaborator

@abangser abangser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a binding acceptance to merge this, but shared a few non-blocking comments to think about!

README.md Outdated Show resolved Hide resolved
Signed-off-by: Bruno Schaatsbergen <[email protected]>
Copy link
Contributor

@elft3r elft3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roberthstrand roberthstrand merged commit 71e84e8 into cncf:main Oct 8, 2024
7 checks passed
@bschaatsbergen bschaatsbergen deleted the add-il-website branch October 8, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en website Related to TAG website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants