Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug for PercentageValue #1443

Closed
wants to merge 1 commit into from
Closed

Conversation

zfb132
Copy link
Contributor

@zfb132 zfb132 commented Nov 22, 2023

I am using the meshlab GUI software to generate the pymeshlab filter script. However, I got an error when pasting the code to a Python file. For example:

>>> ms.generate_sampling_clustered_vertex(threshold = pymeshlab.PercentageValue(1.100005))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'pymeshlab' has no attribute 'PercentageValue'

This PR should fix the bug above.

@alemuntoni
Copy link
Member

Actually, PercentageValue is correct. devel branch of MeshLab is aligned with devel branch of PyMeshLab, and both are still in development. And in the devel branch of PyMeshLab, the class is called PercentageValue. It has been renamed for consistency with other class names.

@alemuntoni alemuntoni closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants