-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign homepage #250
Redesign homepage #250
Conversation
913fcf6
to
4121933
Compare
Hey @KVGarg, TravisCI finished with status TravisBuddy Request Identifier: 7dd7c4e0-8ae4-11e9-b134-4db506c136b3 |
08ac259
to
22598ab
Compare
Travis tests have failedHey @KVGarg, 1st Buildcoala --non-interactive -V
TravisBuddy Request Identifier: b4c8c200-8b49-11e9-bc80-e12f9fe98eab |
Travis tests have failedHey @KVGarg, TravisBuddy Request Identifier: 06a40a60-8b4c-11e9-bc80-e12f9fe98eab |
f9b4f68
to
3a168af
Compare
Travis tests have failedHey @KVGarg, 1st Build./.ci/build.sh
TravisBuddy Request Identifier: 486f6370-8c07-11e9-8a87-b55ed42e4e71 |
3a168af
to
323e60f
Compare
@sks444 @damngamerz @margobra8 |
fc11659
to
7b62ef5
Compare
Travis tests have failedHey @KVGarg, 1st Build./.ci/build.sh
pytest
TravisBuddy Request Identifier: 036b2650-8d98-11e9-9089-57d5c73fda02 |
973c1d0
to
89d72fd
Compare
@sks444 I was thinking, to add the |
1b2ac08
to
84d7920
Compare
Travis tests have failedHey @KVGarg, 1st Buildcoala --non-interactive -V
TravisBuddy Request Identifier: 71b3cd50-b490-11e9-a5f8-ad46f5ea24b0 |
3f2acbd
to
0cafd54
Compare
Travis tests have failedHey @KVGarg, 1st Buildpytest
TravisBuddy Request Identifier: d7e24620-b55c-11e9-a172-292526d14dc1 |
47953a9
to
84adae6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look nice! I just played around with the homepage, but I am not sure what do strings on geolocation map mean. For example, if you click on a certain location icon, it would display a string like e06d397ab187444adde99f33c29e36131ad82273
.
Could you make moban sync commit a separate PR? We can merge that one first. Smaller PRs are much easier to get merged. |
The homepage looks very good! Good job! Would be nice, as @li-boxuan said, to separate the Moban sync into another PR and roll back the head of this one only to include the homepage changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I was thinking why I wasn't receiving any emails from GitHub, I just saw my |
Sorry for l8 rply! Those string are auto generated by |
84adae6
to
ae718af
Compare
I would have done that, but doing so will lead to fail the Travis CI and netlify too. |
Latest Preview can be seen in #252 |
0fe147d
to
7f2877a
Compare
The enhancement includes addition of materialize css, JQuery, responsiveness, and easy-navigation of website features. The easy-navigatibility is achieved by adding a navbar with display of meta -review and gamification leaderboard on homepage. Apart from this, the activity graph url is omitted from website by displaying the graph itslef on the homepage on large devices. Closes coala#255
@abhishalya Can we merge this? |
Yup, keeping this in the queue. |
The enhancement includes addition of materialize
css, JQuery, responsiveness, and easy-navigation
of website features. The easy-navigatibility is
achieved by adding a navbar with display of meta
-review and gamification leaderboard on homepage.
Apart from this, the activity graph url is omitted
from website by displaying the graph itslef on the
homepage on large devices.
Closes https://gitlab.com/coala/GSoC/gsoc-2019/issues/142