Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More library additions #1243

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

More library additions #1243

wants to merge 19 commits into from

Conversation

YarinHeffes
Copy link
Collaborator

Macros: unwrap-as and try-as
Additional standard library functionality.

amorphedstar
amorphedstar reviewed Sep 15, 2024
View reviewed changes
library/ord-map.lisp Outdated Show resolved Hide resolved
amorphedstar
amorphedstar reviewed Sep 15, 2024
View reviewed changes
library/ord-tree.lisp Outdated Show resolved Hide resolved
Izaakwltn
Izaakwltn requested changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@Izaakwltn Izaakwltn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good-

I'm ready to approve it with

  1. An adjusted commit history (squash merges, reverts, wip commits)
  2. add some tests for new functions, especially in ord-tree and ord-map, potentially for try-as and unwrap-as as well

library/string.lisp
@@ -218,12 +218,14 @@ does not have that suffix."
(define-instance (Into Single-Float String)
(define (into z)
(lisp String (z)
(cl:prin1-to-string z))))
(cl:format cl:nil "~F" z)
#+ign(cl:prin1-to-string z))))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ignores

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorphedstar amorphedstar amorphedstar left review comments

@Izaakwltn Izaakwltn Izaakwltn requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YarinHeffes @Izaakwltn @amorphedstar