Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added drop in pass trigger #210

Merged
merged 6 commits into from
Jan 15, 2025
Merged

added drop in pass trigger #210

merged 6 commits into from
Jan 15, 2025

Conversation

Jsnxyz
Copy link
Contributor

@Jsnxyz Jsnxyz commented Jan 13, 2025

fixes #194

@Jsnxyz Jsnxyz requested a review from langalex January 13, 2025 10:16
@langalex
Copy link
Member

scopes added

width: 100,
height: 100,
};
const dropInPassResponse: DropInPassApiResponse = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming. this is not a (full) response but data for one pass.

@Jsnxyz
Copy link
Contributor Author

Jsnxyz commented Jan 14, 2025

Still seem to get this and I have clearly added the scopes.

image

@langalex
Copy link
Member

that part works for me (I hit "connect new account" to be sure the token was renewed). but I can into this error:

Error code: Error while retrieving: The app returned "Invalid parameter". What happened (You are seeing this because you are an admin): Stack trace: ResponseError: {"status":400,"headers":{"content-type":"application/vnd.api+json; charset=utf-8","retry-after":null},"content":"{"errors":[{"title":"Invalid parameter","detail":"2024-12-14T10:48:39.270+00:00 is not a valid date.","source":{"parameter":"filter[valid_on_from]"}}]}",

@Jsnxyz Jsnxyz requested a review from langalex January 14, 2025 11:37
@langalex
Copy link
Member

works now 👍

src/utils/api.ts Outdated
const now = DateTime.now();
const lastMonth = now.minus({ months: 1 });
const nextMonth = now.plus({ months: 1 });
if (format) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the format you are passing the same as what toISODate returns?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sorry. Had an oversight.. I did try it.. but I guess I forgot to reload the platform and just assumed its still not the correct format or something and proceeded to add the format parameter.

@Jsnxyz Jsnxyz requested a review from langalex January 14, 2025 12:30
@Jsnxyz Jsnxyz merged commit ce22720 into main Jan 15, 2025
5 checks passed
@Jsnxyz Jsnxyz deleted the dop branch January 15, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger for Drop-in Passes
2 participants