Skip to content

Commit

Permalink
storage: disable multilevel compactions
Browse files Browse the repository at this point in the history
In their current state, multilevel compactions can cause
momentary spikes in L0 sublevels, resulting in undesirable side-effects
elsewhere.

Fixes #134423.

Epic: none

Release note: None
  • Loading branch information
itsbilal committed Nov 6, 2024
1 parent 03e522a commit 88a7276
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/storage/pebble.go
Original file line number Diff line number Diff line change
Expand Up @@ -891,6 +891,10 @@ func DefaultPebbleOptions() *pebble.Options {
Lower: EncodeMVCCKey(MVCCKey{Key: keys.LocalRangeLockTablePrefix}),
Upper: EncodeMVCCKey(MVCCKey{Key: keys.LocalRangeLockTablePrefix.PrefixEnd()}),
}
// Disable multi-level compaction heuristic for now. See #134423
// for why this was disabled, and what needs to be changed to reenable it.
// This issue tracks re-enablement: https://github.com/cockroachdb/pebble/issues/4139
opts.Experimental.MultiLevelCompactionHeuristic = pebble.NoMultiLevel{}

for i := 0; i < len(opts.Levels); i++ {
l := &opts.Levels[i]
Expand Down

0 comments on commit 88a7276

Please sign in to comment.