Skip to content

Commit

Permalink
bincheck: do not run geos tests on Windows
Browse files Browse the repository at this point in the history
In #106642 we stopped shipping libgeos on Windows, but didn't update the
bincheck test to reflect the change.

Epic: none
Release note: None
  • Loading branch information
rail committed Feb 5, 2024
1 parent a9d6f3c commit d623844
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion build/release/bincheck/bincheck
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ EOF
diff -u expected actual

# Verify libgeos functionality on all platforms except MacOS ARM64 and Windows
if [[ $(uname -om) == "Darwin arm64" ]]; then
if [[ $(uname -om) == "Darwin arm64" || $(uname -o) == "Msys" ]]; then
echo "Skipping libgeos tests"
else
echo "Testing libgeos functionality"
Expand Down
2 changes: 0 additions & 2 deletions build/release/bincheck/download_binary.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ download_and_extract() {
else
curl -sSfL "${binary_url}" > cockroach.zip
7z e -omnt cockroach.zip
mkdir -p mnt/lib
mv mnt/*.dll mnt/lib/
fi

echo "Downloaded ${binary_url}"
Expand Down

0 comments on commit d623844

Please sign in to comment.