Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: add observability metrics into sarama code #117693

Merged
merged 1 commit into from
Feb 6, 2024

Commits on Feb 5, 2024

  1. changefeedccl: add observability metrics into sarama code

    Now that this patch (cockroachdb#117544) has been merged, sarama now acknowledges and
    reacts to kafka server's throttling messages by slowing down. To provide better
    observability into sarama code, this patch adds a metrics registry interceptor
    and a new metrics `changefeed.kafka_throttling_hist_nanos` which tracks time (in
    nanos) spent in sarama's throttling when cockroachdb exceed the kafka quota.
    
    Fixes: cockroachdb#117618
    
    Release note: changefeed.kafka_throttling_hist_nanos has now been added to
    metrics to monitor sarama throttling behavior resulting from exceeding kafka
    quota.
    wenyihu6 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a5bcfca View commit details
    Browse the repository at this point in the history