Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachprod: redirect CRDB logs utility #132586

Merged
merged 2 commits into from
Oct 28, 2024
Merged

roachprod: redirect CRDB logs utility #132586

merged 2 commits into from
Oct 28, 2024

Commits on Oct 28, 2024

  1. roachprod: redirect CRDB logs utility 

    Currently, CRDB log is configured, by roachtest, to log to a file to catch any
logs written to it during a roachtest run. This is usually from a shared test
util that uses the CRDB log. The file sink on the CRDB logger will log program
arguments by default, but this can leak sensitive information.

This PR introduces a log redirect that uses the CRDB log interceptor
functionality instead of using a file sink. This way we can avoid logging the
program arguments.

Epic: None
Release note: None
    @herkolategan
    herkolategan committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c1dc957 View commit details
    Browse the repository at this point in the history

  2. roachtest: replace CRDB file sink log 

    This replaces the initiation of the file sink based CRDB log with the new
interceptor log redirect. It will log to a file in the artifacts directory.

Epic: None
Release note: None
    @herkolategan
    herkolategan committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    666a9cd View commit details
    Browse the repository at this point in the history