keys,roachpb: change default system tenant from tenantID {1} to {2} #133926
+315
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
stevendanna
reviewed
Oct 31, 2024
| sqlEncoder: sqlEncoder{&MinKey, &MaxKey, roachpb.SystemTenantID}, | ||
| // | ||
| // TODO(chandrat) revisit minKey and maxKeys. | ||
| var PrefixlessSystemSQLCodec = SQLCodec{ |
There was a problem hiding this comment.
I think it would be more accurate if we named this:
Suggested change
| var PrefixlessSystemSQLCodec = SQLCodec{ | |
| var PrefixlessSQLCodec = SQLCodec{ |
pkg/roachpb/tenant.go
Outdated
Comment on lines
115
to
134
| return id == SystemTenantID.ToUint64() | ||
| return id == TenantTwo.ToUint64() || id == TenantOne.ToUint64() |
There was a problem hiding this comment.
Perhaps this new logic should only take place if we have the env var set?
By default tenantID {1} is used as system tenant which is prefixless.
`COCKROACH_EXPERIMENTAL_UA` environment variable is used to change
the default system tenant from tenantID {1} to {2}.
shubhamdhama
force-pushed
the
ua4
branch
2 times, most recently
from
b1fe111
to
0c0ef7c
Compare
Co-authored-by: Chandra Thumuluru <[email protected]>
When we start the `TenantTwo` we want it to have `system` as its name from the very beginning. To achieve this, instead of rewriting keys we use KVWriter. `TenantTwo`'s name would become `system`, and `TenantOne`'s name would be whatever is passed to `create_tenant` command (ideally, `main`). Note, we are chaning this value for `TenantTwo`'s `tenants` table, not for the `TenantOne`'s system table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default tenantID {1} is used as system tenant which is prefixless.
COCKROACH_EXPERIMENTAL_UAenvironment variable is used to change the default system tenant from tenantID {1} to {2}.