-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.3: docgen: update SQL diagrams for triggers #135094
Conversation
752b114
to
3f5305a
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice it before, but for future reference we prefer to combine commits like these before merging.
Reviewed 4 of 4 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @taroface)
I unfortunately remembered this too late. Is there a way that I can do it in this PR, or is it also too late for this one? |
bors r=DrewKimball |
👎 Rejected by label |
Backport 4/4 commits from #135051 on behalf of @taroface.
/cc @cockroachdb/release
Made updates to the CREATE TRIGGER and DROP TRIGGER SQL diagrams. These will be used with the docs added in cockroachdb/docs#19129
The generated diagrams:
![image](https://private-user-images.githubusercontent.com/8740013/385579944-8d0122a9-a604-4b5f-91d9-2922322fda56.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODIwNTgsIm5iZiI6MTczOTU4MTc1OCwicGF0aCI6Ii84NzQwMDEzLzM4NTU3OTk0NC04ZDAxMjJhOS1hNjA0LTRiNWYtOTFkOS0yOTIyMzIyZmRhNTYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDEwOTE4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTliNDgzODUxYTc5ZTIxYzVhZDE0MzViMDMzYjQyMzI4NWMwMTRjZDBlZjAzZTMwNTdhMTA3ZmFiZDdiNmVmMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.fOf0zkbdHhCr9oM1G7i80S3JJMCHK2kLZ1Eh4zlP7ic)
Epic: none
Release note: none
Release justification: non-production code change
Release justification: