Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: docgen: update SQL diagrams for triggers #135094

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 13, 2024

Backport 4/4 commits from #135051 on behalf of @taroface.

/cc @cockroachdb/release


Made updates to the CREATE TRIGGER and DROP TRIGGER SQL diagrams. These will be used with the docs added in cockroachdb/docs#19129

The generated diagrams:
image

image

Epic: none
Release note: none
Release justification: non-production code change


Release justification:

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.3-135051 branch from 752b114 to 3f5305a Compare November 13, 2024 18:50
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 13, 2024 18:50
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 13, 2024
Copy link
Author

blathers-crl bot commented Nov 13, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 13, 2024
@blathers-crl blathers-crl bot requested a review from DrewKimball November 13, 2024 18:50
Copy link
Author

blathers-crl bot commented Nov 13, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice it before, but for future reference we prefer to combine commits like these before merging.

Reviewed 4 of 4 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @taroface)

@taroface
Copy link
Collaborator

I didn't notice it before, but for future reference we prefer to combine commits like these before merging.

I unfortunately remembered this too late. Is there a way that I can do it in this PR, or is it also too late for this one?

@taroface
Copy link
Collaborator

bors r=DrewKimball

@craig
Copy link
Contributor

craig bot commented Nov 13, 2024

👎 Rejected by label

@taroface taroface merged commit 2ba561b into release-24.3 Nov 13, 2024
20 of 21 checks passed
@taroface taroface deleted the blathers/backport-release-24.3-135051 branch November 13, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants