backupccl: clean up old backup syntax code #135134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev-cao
requested review from
jeffswenson and
mgartner
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
kev-cao
force-pushed
the
backupccl/cleanup-backup
branch
from
8a33ea4
to
da83941
Compare
msbutler
approved these changes
Nov 14, 2024
| PrevBackupURIs: prevBackupURIs, | ||
| }, nil | ||
| } | ||
|
|
||
| defaultStore, err := makeCloudStorage(ctx, plannedBackupDefaultURI, user) | ||
| if err != nil { | ||
| return ResolvedDestination{}, err |
There was a problem hiding this comment.
as a follow up todo, you could clean up some of the error handling and comments below.
kev-cao
force-pushed
the
backupccl/cleanup-backup
branch
2 times, most recently
from
b8dd321
to
8bf2518
Compare
msbutler
approved these changes
Nov 15, 2024
kev-cao
force-pushed
the
backupccl/cleanup-backup
branch
3 times, most recently
from
d26253e
to
b61e7a8
Compare
The old backup syntax was fully removed in cockroachdb#133610. This commit removes all the old code that ran for the old syntax. Epic: none Release note: none
kev-cao
force-pushed
the
backupccl/cleanup-backup
branch
from
b61e7a8
to
26184f4
Compare
|
TFTR! bors r=msbutler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old backup syntax was fully removed in #133610. This commit removes all the old code that ran for the old syntax.
Epic: none
Release note: none