vecindex: add recall test command #135233
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andy-kimball and @mw5h)
pkg/sql/vecindex/vector_index_test.go line 371 at r1 (raw file):
} return fmt.Sprintf("%.2f%% recall@%d", sumMAP/float64(samples)*100, searchSet.MaxResults)
Could be nice to also display the number of vectors scanned. That doesn't have to happen here, though.
pkg/sql/vecindex/vector_index_test.go line 414 at r1 (raw file):
} // findMAP return mean average precision, which compares a set of predicted
[nit] findMAP return -> findMAP returns
The new "recall" test command computes the percentage of search results that are true nearest results. This is a standard measure of index and search quality. Epic: CRDB-42943 Release note: None
There was a problem hiding this comment.
Reviewable status:
pkg/sql/vecindex/vector_index_test.go line 371 at r1 (raw file):
Previously, DrewKimball (Drew Kimball) wrote…
Could be nice to also display the number of vectors scanned. That doesn't have to happen here, though.
Good suggestion, I went ahead and added that.
pkg/sql/vecindex/vector_index_test.go line 414 at r1 (raw file):
Previously, DrewKimball (Drew Kimball) wrote…
[nit]
findMAP return->findMAP returns
Done.
|
bors r=drewkimball |
The new "recall" test command computes the percentage of search results that are true nearest results. This is a standard measure of index and search quality.
Epic: CRDB-42943
Release note: None