Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add metrics measuring distributed execution #135236

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

sql: add metrics measuring distributed execution #135236

wants to merge 3 commits into from
+64 −26

Commits on Nov 15, 2024

  1. sql: add sql.distsql.select.distributed.count metrics 

    Add a new planFlag and counter to EngineMetrics. Note that the planFlag
is set if *any* part of a query uses distributed execution, including
pre- or post-queries. This seemed both simpler and more likely to be
useful than only counting main queries that use distributed execution.

Release note (ops change): Add two new metrics,
`sql.distsql.select.distributed.count` and
`sql.distsql.select.distributed.count.internal`. These metrics count the
number of SELECT statements that actually execute with full or partial
distribution. These metrics differ from `sql.distsql.select.count` and
`sql.distsql.select.count.internal` in that the latter count the number
of SELECT statements that are *planned* with full or partial
distribution, but might not necessarily execute with full or partial
distribution, depending on the location of data.
    @michae2
    michae2 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5cc9d33 View commit details
    Browse the repository at this point in the history

  2. sql: add sql.distsql.distributed.count metric 

    Release note (ops change): Add new metric
`sql.distsql.distributed.count` which counts the number of invocations
of the DistSQL engine with full or partial distribution. (This is in
contrast to `sql.distsql.queries.total` which counts the total number of
invocations of the DistSQL engine.)
    @michae2
    michae2 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    416a28c View commit details
    Browse the repository at this point in the history

  3. sql: clarify scope of a few sql.distsql metrics 

    Release note (ops change): Add some clarification that the following
metrics count invocations of the DistSQL engine and not SQL queries
(which could each result in multiple invocations of the DistSQL engine):

- `sql.distsql.queries.active`
- `sql.distsql.queries.total`
- `sql.distsql.distributed.count`
    @michae2
    michae2 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    4f4dce1 View commit details
    Browse the repository at this point in the history