Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.2: scjob: support handling permanent job errors #135274

Open
wants to merge 1 commit into
base: release-24.2
Choose a base branch
from
Open

release-24.2: scjob: support handling permanent job errors #135274

wants to merge 1 commit into from

Commits on Nov 15, 2024

  1. scjob: support handling permanent job errors 

    Previously, when a descriptor was detect as a dropped the error was
marked as permanent for schema change jobs. However, the declarative
schema change job framework did not properly handle these errors. As a
result, even if the erorr was tagged we would keep attempting rollbacks.
To address this, this patch makes the OnFailOrCancel logic detect
permanent errors and allows them to cause the schema change to hit the
terminal state.

Fixes: cockroachdb#131405
Release note: None
    @fqazi
    fqazi committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    729e52a View commit details
    Browse the repository at this point in the history