cloud/gcp: fix cloud invalid bucket test #135320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epic: none Release note: None
|
This change is |
|
what prompted this change? Like, this test is checking for a specific error code. Did something change that means we need to update the error code? Did a test just flake? |
|
This doesn't work on master anymore. I imagine Google changed their responses, or possibly somebody actually claimed that bucket. Edit: probably nobody claimed the bucket. |
|
WOAH somebody took the bucket. Let me change this to randomize the bucket name instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud unit tests succeeded here
Epic: none
Release note: None