Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: add TestFlowControlSendQueueManyInflight test #135331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kvoli
Copy link
Collaborator

@kvoli kvoli commented Nov 15, 2024

Add a new RACv2 integration test:
TestFlowControlSendQueueManyInflight, which attempts to do the following:

-- We will exhaust the tokens across all streams while admission is blocked,
-- using a single 16 MiB (deduction, the write itself is small) write. Then,
-- we will write a thousand or so entries (@ 4KiB deduction) which should be
-- queued towards one of the replica send streams, while the other has a send
-- queue prevented from forming. Lastly, we will unblock admission and stress
-- the raft in-flights tracker as the queue is drained.

Part of: #132614
Release note: None

@kvoli kvoli requested a review from a team as a code owner November 15, 2024 21:14
@kvoli kvoli self-assigned this Nov 15, 2024
@kvoli kvoli added the backport-24.3.x Flags PRs that need to be backported to 24.3 label Nov 15, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Add a new RACv2 integration test:
`TestFlowControlSendQueueManyInflight`, which attempts to do the
following:

```sql
-- We will exhaust the tokens across all streams while admission is blocked,
-- using a single 16 MiB (deduction, the write itself is small) write. Then,
-- we will write a thousand or so entries (@ 4KiB deduction) which should be
-- queued towards one of the replica send streams, while the other has a send
-- queue prevented from forming. Lastly, we will unblock admission and stress
-- the raft in-flights tracker as the queue is drained.
```

Part of: cockroachdb#132614
Release note: None
@kvoli kvoli force-pushed the 241115.rac-test-many-inflight branch from f34e30d to 1ad6668 Compare November 15, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants