rac2: fix incorrect assertion when send-queue becomes empty #135500
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The indexToSend in this case was being updated before the loop, but the preciseSizeSum was incrementally deducted inside the loop. This meant that if more than one item was being popped and the queue was becoming empty, the code would incorrectly assert that preciseSizeSum should be 0 after subtracting the tokens for the first entry. Fixes cockroachdb#135289, cockroachdb#135344 Epic: none Release note: None
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
kvoli
approved these changes
Nov 16, 2024
|
TFTR! |
|
bors r=kvoli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indexToSend in this case was being updated before the loop, but the preciseSizeSum was incrementally deducted inside the loop. This meant that if more than one item was being popped and the queue was becoming empty, the code would incorrectly assert that preciseSizeSum should be 0 after subtracting the tokens for the first entry.
Fixes #135289, #135344
Epic: none
Release note: None