Skip to content

Commit

Permalink
dec 31
Browse files Browse the repository at this point in the history
  • Loading branch information
timgraham committed Jan 1, 2025
1 parent 4e5d603 commit 757f471
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
5 changes: 5 additions & 0 deletions django_cockroachdb/features.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,10 @@ def django_test_expected_failures(self):
'schema.tests.SchemaTests.test_text_field_with_db_index_to_fk',
# CockroachDB doesn't support dropping the primary key.
'schema.tests.SchemaTests.test_alter_int_pk_to_int_unique',
# unimplemented: primary key dropped without subsequent addition of
# new primary key in same transaction
# https://github.com/cockroachdb/cockroach/issues/48026
'migrations.test_operations.OperationTests.test_composite_pk_operations',
# CockroachDB doesn't support changing the primary key of table.
# psycopg.errors.InvalidColumnReference: column "id" is referenced
# by the primary key
Expand Down Expand Up @@ -207,6 +211,7 @@ def django_test_expected_failures(self):
# https://github.com/cockroachdb/cockroach/issues/91396
'backends.tests.EscapingChecks.test_parameter_escaping',
'backends.tests.EscapingChecksDebug.test_parameter_escaping',
'composite_pk.test_update.CompositePKUpdateTests.test_bulk_update_comments',
'constraints.tests.CheckConstraintTests.test_database_default',
'expressions.tests.BasicExpressionsTests.test_annotate_values_filter',
'expressions_case.tests.CaseDocumentationExamples.test_lookup_example',
Expand Down
16 changes: 16 additions & 0 deletions django_cockroachdb_gis/features.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from django.contrib.gis.db.backends.postgis.features import (
DatabaseFeatures as PostGISFeatures,
)
from django.db.backends.postgresql.psycopg_any import is_psycopg3
from django.utils.functional import cached_property

from django_cockroachdb.features import DatabaseFeatures as CockroachFeatures
Expand Down Expand Up @@ -72,7 +73,22 @@ def django_test_expected_failures(self):
# 3D opclass not present on CockroachDB:
# https://github.com/cockroachdb/cockroach/issues/47420#issuecomment-969578772
'gis_tests.gis_migrations.test_operations.OperationTests.test_add_3d_field_opclass',
# QuerySet.bulk_create() doesn't work with geometries after
# https://github.com/django/django/commit/a16eedcf9c69d8a11d94cac1811018c5b996d491
# could not parse geometry: error parsing EWKB hex: encoding/hex:
# invalid byte: U+003A ':'
# https://github.com/cockroachdb/cockroach/issues/138140
'gis_tests.geoapp.test_functions.GISFunctionsTests.test_area_lookups',
})
if is_psycopg3:
expected_failures.update({
# QuerySet.bulk_create() doesn't work with geometries after
# https://github.com/django/django/commit/a16eedcf9c69d8a11d94cac1811018c5b996d491
# could not parse geometry: error parsing EWKB hex: encoding/hex:
# invalid byte: U+003A ':'
# https://github.com/cockroachdb/cockroach/issues/138140
'gis_tests.geoapp.test_functions.GISFunctionsTests.test_area_lookups',
})
if self.uses_server_side_binding:
expected_failures.update({
# unknown signature: st_scale(geometry, int, int)
Expand Down

0 comments on commit 757f471

Please sign in to comment.