Skip to content

Commit

Permalink
beta 1
Browse files Browse the repository at this point in the history
  • Loading branch information
timgraham committed Apr 19, 2024
1 parent e67b000 commit ec75ca2
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ jobs:
# use_psycopg2: psycopg2
#- crdb-version: v23.2.0
# use_server_side_binding: server_side_binding
- crdb-version: v24.1.0-alpha.4
- crdb-version: v24.1.0-alpha.4
- crdb-version: v24.1.0-beta.1
- crdb-version: v24.1.0-beta.1
use_psycopg2: psycopg2
- crdb-version: v24.1.0-alpha.4
- crdb-version: v24.1.0-beta.1
use_server_side_binding: server_side_binding
- crdb-version: LATEST
- crdb-version: LATEST
Expand Down
11 changes: 11 additions & 0 deletions django_cockroachdb/features.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ def introspected_field_types(self):
def is_cockroachdb_23_2(self):
return self.connection.cockroachdb_version >= (23, 2)

@cached_property
def is_cockroachdb_24_1(self):
return self.connection.cockroachdb_version >= (24, 1)

@cached_property
def django_test_expected_failures(self):
expected_failures = super().django_test_expected_failures
Expand Down Expand Up @@ -196,6 +200,13 @@ def django_test_expected_failures(self):
# https://github.com/cockroachdb/cockroach/issues/73587#issuecomment-988408190
'aggregation.tests.AggregateTestCase.test_aggregation_default_using_decimal_from_database',
})
if self.is_cockroachdb_24_1:
# USING cast required: https://github.com/cockroachdb/cockroach/issues/82416#issuecomment-2029803229
expected_failures.update({
'schema.tests.SchemaTests.test_alter_text_field_to_date_field',
'schema.tests.SchemaTests.test_alter_text_field_to_datetime_field',
'schema.tests.SchemaTests.test_alter_text_field_to_time_field',
})
if self.uses_server_side_binding:
expected_failures.update({
# could not determine data type of placeholder:
Expand Down

0 comments on commit ec75ca2

Please sign in to comment.