Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release note for bug fix for iterator over file sinks #19180

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Add release note for bug fix for iterator over file sinks #19180

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
356dc27
add release note requested by customer on a fix we made to enable the…
shannonbradshaw Nov 26, 2024
6de14de
Merge branch 'main' into file-sink-bug-fix
shannonbradshaw Nov 26, 2024
f355f02
Merge branch 'main' into file-sink-bug-fix
shannonbradshaw Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/current/_includes/releases/v24.1/v24.1.5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Release Date: September 25, 2024
- Fixed a bug where the [`require_explicit_primary_keys` session variable]({% link v24.1/session-variables.md %}#require-explicit-primary-keys) would aggressively prevent all [`CREATE TABLE`]({% link v24.1/create-table.md %}) statements from working. [#129907][#129907]
- Fixed a slow-building memory leak when using [Kerberos authentication]({% link v24.1/gssapi_authentication.md %}). [#130318][#130318]
- Fixed a potential memory leak in [changefeeds]({% link v24.1/change-data-capture-overview.md %}) using a [cloud storage sink]({% link v24.1/changefeed-sinks.md %}#cloud-storage-sink). The memory leak could occur if both the cluster settings [`changefeed.fast_gzip.enabled`]({% link v24.1/cluster-settings.md %}#setting-changefeed-fast-gzip-enabled) and [`changefeed.cloudstorage.async_flush.enabled`]({% link v24.1/cluster-settings.md %}) are set to `true` and the changefeed received an error while attempting to write to the cloud storage sink. [#130626][#130626]
- Fixed a bug that prevented buffered file sinks from being included when iterating over all file sinks. This led to problems such as the `debug zip` command not being able to fetch logs for a cluster where buffering was enabled. [#130158][#130158]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion for all versions:

Suggested change
- Fixed a bug that prevented buffered file sinks from being included when iterating over all file sinks. This led to problems such as the `debug zip` command not being able to fetch logs for a cluster where buffering was enabled. [#130158][#130158]
- Fixed a bug that incorrectly excluded buffered file sinks when iterating over all file sinks. This led to problems such as the `debug zip` command not being able to fetch logs for a cluster where buffering was enabled. [#130158][#130158]


[#122636]: https://github.com/cockroachdb/cockroach/pull/122636
[#128085]: https://github.com/cockroachdb/cockroach/pull/128085
Expand All @@ -80,6 +81,7 @@ Release Date: September 25, 2024
[#130046]: https://github.com/cockroachdb/cockroach/pull/130046
[#130050]: https://github.com/cockroachdb/cockroach/pull/130050
[#130051]: https://github.com/cockroachdb/cockroach/pull/130051
[#130158]: https://github.com/cockroachdb/cockroach/pull/130158
[#130318]: https://github.com/cockroachdb/cockroach/pull/130318
[#130510]: https://github.com/cockroachdb/cockroach/pull/130510
[#130584]: https://github.com/cockroachdb/cockroach/pull/130584
Expand Down
2 changes: 2 additions & 0 deletions src/current/_includes/releases/v24.2/v24.2.3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ Release Date: September 25, 2024
- Fixed a slow-building memory leak that could occur when using [Kerberos authentication]({% link v24.2/gssapi_authentication.md %}). [#130319][#130319]
- Fixed a bug that could result in the inability to garbage collect an [MVCC]({% link v24.2/architecture/storage-layer.md %}#mvcc) range tombstone within a [global table]({% link v24.2/table-localities.md %}#global-tables). [#130951][#130951]
- Fixed a potential memory leak in changefeeds using a [cloud storage sink]({% link v24.2/changefeed-sinks.md %}#cloud-storage-sink). The memory leak could occur if both [`changefeed.fast_gzip.enabled`]({% link v24.2/cluster-virtualization-setting-scopes.md %}) and `changefeed.cloudstorage.async_flush.enabled` are true and the changefeed received an error while attempting to write to the cloud storage sink. [#130625][#130625]
- Fixed a bug that prevented buffered file sinks from being included when iterating over all file sinks. This led to problems such as the `debug zip` command not being able to fetch logs for a cluster where buffering was enabled. [#130158][#130158]

<div class="release-note-contributors" markdown="1">

Expand Down Expand Up @@ -74,6 +75,7 @@ This release includes 94 merged PRs by 38 authors.
[#129809]: https://github.com/cockroachdb/cockroach/pull/129809
[#129895]: https://github.com/cockroachdb/cockroach/pull/129895
[#129908]: https://github.com/cockroachdb/cockroach/pull/129908
[#130158]: https://github.com/cockroachdb/cockroach/pull/130158
[#130319]: https://github.com/cockroachdb/cockroach/pull/130319
[#130511]: https://github.com/cockroachdb/cockroach/pull/130511
[#130582]: https://github.com/cockroachdb/cockroach/pull/130582
Expand Down
2 changes: 2 additions & 0 deletions src/current/_includes/releases/v24.3/v24.3.0-alpha.1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ Release Date: October 9, 2024
- Fixed a bug where [jobs]({% link v24.3/show-jobs.md %}) created in a session with non-zero session [timezone offsets]({% link v24.3/set-vars.md %}#set-time-zone) could hang before starting, or report incorrect creation times when viewed in [`SHOW JOBS`]({% link v24.3/show-jobs.md %}) and the [DB Console]({% link v24.3/ui-overview.md %}). [#123632][#123632]
- Fixed a bug which could result in [changefeeds using CDC queries]({% link v24.3/create-schedule-for-changefeed.md %}#create-a-scheduled-changefeed-with-cdc-queries) failing due to a system table being [garbage collected]({% link v24.3/architecture/storage-layer.md %}#garbage-collection). [#131027][#131027]
- [`ALTER COLUMN TYPE`]({% link v24.3/alter-table.md %}#convert-to-a-different-data-type) now errors out when there is a [partial index]({% link v24.3/partial-indexes.md %}) that is dependent on the column being altered. [#131590][#131590]
- Fixed a bug that prevented buffered file sinks from being included when iterating over all file sinks. This led to problems such as the `debug zip` command not being able to fetch logs for a cluster where buffering was enabled. [#130158][#130158]

<h3 id="v24-3-0-alpha-1-performance-improvements">Performance improvements</h3>

Expand Down Expand Up @@ -292,6 +293,7 @@ Release Date: October 9, 2024
[#130103]: https://github.com/cockroachdb/cockroach/pull/130103
[#130110]: https://github.com/cockroachdb/cockroach/pull/130110
[#130117]: https://github.com/cockroachdb/cockroach/pull/130117
[#130158]: https://github.com/cockroachdb/cockroach/pull/130158
[#130164]: https://github.com/cockroachdb/cockroach/pull/130164
[#130167]: https://github.com/cockroachdb/cockroach/pull/130167
[#130198]: https://github.com/cockroachdb/cockroach/pull/130198
Expand Down
Loading