Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for changefeed privileges in v25.1 #19290

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kathancox
Copy link
Contributor

@kathancox kathancox commented Jan 9, 2025

Fixes DOC-12058

This PR updates the changefeed privilege docs to deprecate the use of the CHANGEFEED privilege for viewing and managing changefeed jobs on tables users have the privilege on (from v25.1). Instead, documenting that users should use job ownership or global privileges to view and manage jobs.

This PR also adds the ALTER JOB statement, which can transfer job ownership between users or roles. (SQL diagram not live yet until the eng work is merged into master.)

Preview

https://deploy-preview-19290--cockroachdb-docs.netlify.app/docs/v25.1/alter-job.html
https://deploy-preview-19290--cockroachdb-docs.netlify.app/docs/v25.1/create-changefeed.html#required-privileges

Copy link

github-actions bot commented Jan 9, 2025

Files changed:

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 98bc23d
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/677ff4efa67c4300091350fe

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 98bc23d
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/677ff4ef2caa930008fab949

Copy link

netlify bot commented Jan 9, 2025

Netlify Preview

Name Link
🔨 Latest commit 98bc23d
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/677ff4ef549cb500088d3832
😎 Deploy Preview https://deploy-preview-19290--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kathancox kathancox requested a review from dt January 13, 2025 19:18
@kathancox kathancox marked this pull request as ready for review January 13, 2025 19:18
@kathancox
Copy link
Contributor Author

Hey @dt, can you ptal? The SQL diagram for alter job will not yet render because the release branch is not ready — I'll have to wait to merge for this.

@kathancox kathancox marked this pull request as draft January 13, 2025 19:19
@dt
Copy link
Member

dt commented Jan 13, 2025

Thanks for picking this up!

@kathancox kathancox requested a review from rmloveland January 16, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants