objstorage: optimize MemObj.NewReadHandle #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
force-pushed
the
mem-obj-handle-alloc
branch
from
a46949c
to
125611e
Compare
Better implementation for `MemObj.NewReadHandle` which doesn't allocate (the allocation shows up in profiles and is a red-herring as the production path would use a preallocated handle).
RaduBerinde
force-pushed
the
mem-obj-handle-alloc
branch
from
125611e
to
cbf4fba
Compare
jbowens
approved these changes
Oct 19, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaduBerinde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better implementation for
MemObj.NewReadHandlewhich doesn'tallocate (the allocation shows up in microbenchmark profiles and is a
red-herring as the production path would use a preallocated handle).