colblk: add a KeySchema-specific header #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jbowens
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
nice
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaduBerinde)
RaduBerinde
force-pushed
the
custom-header
branch
from
c5dca6e
to
ab2e0ea
Compare
We add a fixed-size KeySchema-specific header to the beginning of the custom block header. A KeySchema implementation can store there information and retrieve it when initializing the key seeker. We use this to add a byte to cockroach blocks which indicates what types of suffixes are contained in the block (mvcc, empty, non-mvcc). This will be used for optimized fast paths for the common cases.
RaduBerinde
force-pushed
the
custom-header
branch
from
ab2e0ea
to
410a16c
Compare
|
I was wondering - should we encode the size of the keyschema header as well? Seems fragile in that if we change |
|
Yeah I think that's a good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a fixed-size KeySchema-specific header to the beginning of the
custom block header. A KeySchema implementation can store there
information and retrieve it when initializing the key seeker.
We use this to add a byte to cockroach blocks which indicates what
types of suffixes are contained in the block (mvcc, empty, non-mvcc).
This will be used for optimized fast paths for the common cases.