block: remove unnecessary CompressAndChecksum allocation #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allocation snuck in during the block package refactors.
```
│ old.txt │ new.txt │
│ allocs/op │ allocs/op vs base │
Writer/format=(Pebble,v2)/block=4.0KB/filter=true/compression=NoCompression-10 18.985k ± 0% 9.533k ± 0% -49.79% (p=0.000 n=10)
Writer/format=(Pebble,v2)/block=4.0KB/filter=true/compression=Snappy-10 18.991k ± 0% 9.536k ± 0% -49.79% (p=0.000 n=10)
Writer/format=(Pebble,v2)/block=4.0KB/filter=true/compression=ZSTD-10 66.29k ± 0% 56.84k ± 0% -14.25% (p=0.000 n=10)
Writer/format=(Pebble,v2)/block=4.0KB/filter=false/compression=NoCompression-10 18.974k ± 0% 9.521k ± 0% -49.82% (p=0.000 n=10)
Writer/format=(Pebble,v2)/block=4.0KB/filter=false/compression=Snappy-10 18.978k ± 0% 9.525k ± 0% -49.81% (p=0.000 n=10)
Writer/format=(Pebble,v2)/block=4.0KB/filter=false/compression=ZSTD-10 66.27k ± 0% 56.83k ± 0% -14.26% (p=0.000 n=10)
Writer/format=(Pebble,v2)/block=32KB/filter=true/compression=NoCompression-10 2.377k ± 0% 1.218k ± 0% -48.76% (p=0.000 n=10)
Writer/format=(Pebble,v2)/block=32KB/filter=true/compression=Snappy-10 2.379k ± 0% 1.220k ± 0% -48.72% (p=0.000 n=10)
Writer/format=(Pebble,v2)/block=32KB/filter=true/compression=ZSTD-10 8.184k ± 0% 7.024k ± 0% -14.17% (p=0.000 n=10)
Writer/format=(Pebble,v2)/block=32KB/filter=false/compression=NoCompression-10 2.365k ± 0% 1.207k ± 0% -48.96% (p=0.000 n=10)
Writer/format=(Pebble,v2)/block=32KB/filter=false/compression=Snappy-10 2.366k ± 0% 1.208k ± 0% -48.95% (p=0.000 n=10)
Writer/format=(Pebble,v2)/block=32KB/filter=false/compression=ZSTD-10 8.172k ± 0% 7.011k ± 0% -14.21% (p=0.000 n=10)
```
Fix cockroachdb#4090.
|
This change is |
jbowens
commented
Oct 21, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @itsbilal)
-- commits line 11 at r1:
why does compression=ZSTD result in so many allocations???
jbowens
commented
Oct 21, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @itsbilal)
Previously, jbowens (Jackson Owens) wrote…
why does compression=ZSTD result in so many allocations???
RaduBerinde
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @itsbilal)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allocation snuck in during the block package refactors.
Fix #4090.