tool: print sstable format in properties #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
itsbilal
force-pushed
the
tool-sstable-format
branch
from
4066d64
to
b2a3ead
Compare
RaduBerinde
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @aadityasondhi and @itsbilal)
tool/sstable.go line 313 at r1 (raw file):
tw := tabwriter.NewWriter(stdout, 2, 1, 2, ' ', 0) fmt.Fprintf(tw, "format\t\n")
[nit] Why a tab before newline? Also, can't we just do "format\t%s\n", format.String()?
Currently, there's no pebble command-line tool that prints an sstable's format. This change prints the sstable's format in the sstable properties command.
itsbilal
force-pushed
the
tool-sstable-format
branch
from
b2a3ead
to
638ad87
Compare
itsbilal
commented
Nov 5, 2024
There was a problem hiding this comment.
TFTR!
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @aadityasondhi)
tool/sstable.go line 313 at r1 (raw file):
Previously, RaduBerinde wrote…
[nit] Why a tab before newline? Also, can't we just do
"format\t%s\n", format.String()?
Ah, I copied what size was doing. Simplified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's no pebble command-line tool that prints an sstable's format. This change prints the sstable's format in the sstable properties command.