Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sstable: reconcile out-of-order key error messages #4147

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Nov 8, 2024

When keys are written to a sstable writer out-of-order, the writer returns an error message. The error messages returned from the row-based and column-based writers varied, in part because the columnar writer did not readily have the previous key at hand. This commit adapts the column writer to synthesize the previous user key for the purpose of embedding it within the returned error message.

This will ensure cockroach unit tests that assert on these errors behave correctly when metamorphically switching between row and column blocks.

When keys are written to a sstable writer out-of-order, the writer returns an
error message. The error messages returned from the row-based and column-based
writers varied, in part because the columnar writer did not readily have the
previous key at hand. This commit adapts the column writer to synthesize the
previous user key for the purpose of embedding it within the returned error
message.
@jbowens jbowens requested a review from a team as a code owner November 8, 2024 20:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens
Copy link
Collaborator Author

jbowens commented Nov 8, 2024

TFTR!

@jbowens jbowens merged commit 4769315 into cockroachdb:master Nov 8, 2024
23 checks passed
@jbowens jbowens deleted the unify-errmsg branch November 8, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants