cache: misc tiny cleanups #4149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sumeerbhola
commented
Nov 8, 2024
sumeerbhola
commented
- Removed entry.peekValue, since there was existing code in clockpro.go that directly accesses e.val, and the method indirection hinders readability.
- Updated the comment about cgo pointer rules since entry no longer points to shard.
- Removed the comment about shard size which suggested that all the blocks of a file are mapped to the same shard, since that is not true.
- Added an assertion when a test entry has a value being set.
- Removed entry.peekValue, since there was existing code in clockpro.go that directly accesses e.val, and the method indirection hinders readability. - Updated the comment about cgo pointer rules since entry no longer points to shard. - Removed the comment about shard size which suggested that all the blocks of a file are mapped to the same shard, since that is not true. - Added an assertion when a test entry has a value being set.
|
This change is |
RaduBerinde
approved these changes
Nov 9, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sumeerbhola)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.