metamorphic: add a test option to make downloadOp no-op #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if we had external storage enabled, we'd always download in a download op. This meant we didn't really test cases where a download could change the state of the LSM relative to not doing the download. This change adds a metamorphic test option (toggled randomly) that disables the download operation in 50% of runs.
|
This change is |
sumeerbhola
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @itsbilal)
metamorphic/ops.go line 207 at r1 (raw file):
func (o *downloadOp) run(t *Test, h historyRecorder) { if t.testOpts.disableDownloads { h.Recordf("%s // %v", o, nil)
is there something that could cause the Download to fail and so a non-nil error would cause a false positive diff and test failure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if we had external storage enabled, we'd always download in a download op. This meant we didn't really test cases where a download could change the state of the LSM relative to not doing the download.
This change adds a metamorphic test option (toggled randomly) that disables the download operation in 50% of runs.