Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

Refractor button unit tests to use react testing library #229

Merged

Conversation

tharun208
Copy link
Contributor

Refractor button unit tests to use react testing library

  • Add react testing library library to package.json
  • refractor Button component unit tests from to use react testing library and not enzyme.

Checklist

  • I have written or updated the test for the changes I made
  • I have updated the README of the package I'm working in to reflect my changes
  • I have added or updated Storybook if appropriate for my changes

Fixes #83

@tharun208 tharun208 changed the title Refractor/button rtl tests Refractor button unit tests to use react testing library Feb 28, 2021
@tharun208 tharun208 force-pushed the refractor/button_rtl_tests branch from 04f6957 to cc98b27 Compare February 28, 2021 13:30
Copy link
Contributor

@nathanstilwell nathanstilwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for the contribution. 🎉

@nathanstilwell nathanstilwell merged commit d4c612d into cockroachdb:master Mar 9, 2021
@tharun208 tharun208 deleted the refractor/button_rtl_tests branch June 25, 2021 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui-components] refactor Button tests
2 participants