Support certificates rotation #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading pgx to v5 will allow to use the reset function, which would close all the connections but without closing the pool. Signed-off-by: Ihab Soliman <[email protected]>
Added a new switch flag when starting the server to enable reloading certificates, and defaulted to `false` for backward compatibility. Introduced two new exposed functions to the database factory instead of changing the original functions signature for both ease of use and not breaking a lot of places in the codebase. The reload function will be triggered (if enabled) on every new connection; Depending on the lifetime of the connection, when it ends, creating a new connection will always reload the certificates from the path. The `Reset` function on `sighup` will close all the connections but not close the pool, allowing new connections to be established. Signed-off-by: Ihab Soliman <[email protected]>
Signed-off-by: Ihab Soliman <[email protected]>
Signed-off-by: Ihab Soliman <[email protected]>
|
Hi @ihab-soliman-form3, could you review and sign the Contributor License Agreement at https://cla.crdb.dev/cockroachlabs/visus ? Thank you! |
|
@ihab-soliman-form3 thanks for the submission. Closing in favor of #107. |
|
@sravotto thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cockroachdb supports certificate rotation using
sighup, visus does supportsighupbut it doesn't update the certificates used, the goal of this PR is to handle certificate rotation to be able to run visus as a sidecar with cockroachdb and both having the same process for certificate rotation.Changes:
Added a new switch flag when starting the server to enable reloading
certificates, and defaulted to
falsefor backward compatibility.Introduced two new exposed functions to the database factory instead of
changing the original functions signature for both ease of use and not
breaking a lot of places in the codebase.
The reload function will be triggered (if enabled) on every new connection;
Depending on the lifetime of the connection, when it ends, creating a
new connection will always reload the certificates from the path.
The
Resetfunction onsighupwill close all the connections but notclose the pool, allowing new connections to be established.
Closes #94
This change is