platform: add GPA to validate_page_range()

validate_page_range() currently takes GVA due to the design of
PVALIDATE. In the case of TDX, GPA is required for page acceptance.

Add an additional input, paddr (PhysAddr), to validate_page_range(). An
explicit input for GPA is required because virt_to_phys() is not always
available. The input region may be out of range for the current
KERNEL_MAPPING.

Signed-off-by: Peter Fang <[email protected]>

kernel/src/cpu/idt/common.rs

@@ -215,7 +215,7 @@ impl WriteLockGuard<'static, IDT> {
     /// Load an IDT. Its lifetime must be static so that its entries are
     /// always available to the CPU.
     pub fn load(&self) {
-        let desc: IdtDesc = IdtDesc {
+        let desc = IdtDesc {
             size: (IDT_ENTRIES * 16) as u16,
             address: VirtAddr::from(self.entries.as_ptr()),
         };

kernel/src/igvm_params.rs

@@ -181,7 +181,7 @@ impl IgvmParams<'_> {
         }
 
         let mem_map_va_region = MemoryRegion::<VirtAddr>::new(mem_map_va, mem_map_region.len());
-        platform.validate_page_range(mem_map_va_region)?;
+        platform.validate_page_range(mem_map_va_region, mem_map_region.start())?;
 
         // Calculate the maximum number of entries that can be inserted.
         let max_entries = fw_info.memory_map_page_count as usize * PAGE_SIZE

kernel/src/mm/page_visibility.rs

@@ -71,7 +71,7 @@ pub fn make_page_private(vaddr: VirtAddr) -> Result<(), SvsmError> {
     )?;
 
     // Revoke page validation before changing page state.
-    platform.validate_page_range(MemoryRegion::new(vaddr, PAGE_SIZE))?;
+    platform.validate_page_range(MemoryRegion::new(vaddr, PAGE_SIZE), paddr)?;
     if valid_bitmap_valid_addr(paddr) {
         valid_bitmap_set_valid_4k(paddr);
     }

kernel/src/platform/mod.rs

@@ -75,7 +75,11 @@ pub trait SvsmPlatform {
     ) -> Result<(), SvsmError>;
 
     /// Marks a range of pages as valid for use as private pages.
-    fn validate_page_range(&self, region: MemoryRegion<VirtAddr>) -> Result<(), SvsmError>;
+    fn validate_page_range(
+        &self,
+        region: MemoryRegion<VirtAddr>,
+        paddr: PhysAddr,
+    ) -> Result<(), SvsmError>;
 
     /// Marks a range of pages as invalid for use as private pages.
     fn invalidate_page_range(&self, region: MemoryRegion<VirtAddr>) -> Result<(), SvsmError>;

kernel/src/platform/native.rs

@@ -88,7 +88,11 @@ impl SvsmPlatform for NativePlatform {
     }
 
     /// Marks a range of pages as valid for use as private pages.
-    fn validate_page_range(&self, _region: MemoryRegion<VirtAddr>) -> Result<(), SvsmError> {
+    fn validate_page_range(
+        &self,
+        _region: MemoryRegion<VirtAddr>,
+        _paddr: PhysAddr,
+    ) -> Result<(), SvsmError> {
         Ok(())
     }
 

kernel/src/platform/snp.rs

@@ -127,7 +127,11 @@ impl SvsmPlatform for SnpPlatform {
     }
 
     /// Marks a range of pages as valid for use as private pages.
-    fn validate_page_range(&self, region: MemoryRegion<VirtAddr>) -> Result<(), SvsmError> {
+    fn validate_page_range(
+        &self,
+        region: MemoryRegion<VirtAddr>,
+        _paddr: PhysAddr,
+    ) -> Result<(), SvsmError> {
         pvalidate_range(region, PvalidateOp::Valid)
     }
 

kernel/src/platform/tdp.rs

@@ -83,7 +83,11 @@ impl SvsmPlatform for TdpPlatform {
         Err(SvsmError::Tdx)
     }
 
-    fn validate_page_range(&self, _region: MemoryRegion<VirtAddr>) -> Result<(), SvsmError> {
+    fn validate_page_range(
+        &self,
+        _region: MemoryRegion<VirtAddr>,
+        _paddr: PhysAddr,
+    ) -> Result<(), SvsmError> {
         Err(SvsmError::Tdx)
     }
 

kernel/src/stage2.rs

@@ -134,7 +134,7 @@ fn map_and_validate(
             PageStateChangeOp::Private,
         )?;
     }
-    platform.validate_page_range(vregion)?;
+    platform.validate_page_range(vregion, paddr)?;
     valid_bitmap_set_valid_range(paddr, paddr + vregion.len());
     Ok(())
 }