Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ASTC textures were not displayed correctly on some devices. #17763

Open
wants to merge 3 commits into
base: v3.8.5
Choose a base branch
from

Conversation

yoki0805
Copy link
Contributor

@yoki0805 yoki0805 commented Oct 22, 2024

Device: Lenovo Tab M10 FHD Plus
Chip: MediaTek Helio P22T (MT8768T)
Platform: Web-mobile

Unable to display ASTC textures correctly.
Screenshot_2024-10-24-14-31-58-549

After the fix.
Screenshot_2024-10-24-14-34-43-124

Test demo:
astc-test.zip

Reproduction steps:

  1. A specific device is required.
  2. Use non-power-of-two ASTC textures.
  3. Build the project.
  4. Run on the device.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

github-actions bot commented Oct 22, 2024

⚠️ Package size ⤴ 190 bytes, old: 5445998, new: 5446188

Interface Check Report

This pull request does not change any public interfaces !

@yoki0805 yoki0805 closed this Oct 22, 2024
@yoki0805 yoki0805 reopened this Oct 22, 2024
@yoki0805 yoki0805 marked this pull request as draft October 22, 2024 09:45
@dumganhar dumganhar requested a review from star-e October 22, 2024 13:03
@yoki0805
Copy link
Contributor Author

This demo only tested cases with Texture_2D & Cube_Map, I wasn't able to test cases with Texture_2D_Array & Texture_3D.
Should the isFullCopy check also be applied to Texture_2D_Array & Texture_3D?

@yoki0805 yoki0805 marked this pull request as ready for review October 25, 2024 02:41
@star-e
Copy link
Contributor

star-e commented Oct 25, 2024

Thanks for your pr! We will investigate this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants