Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add box2d JSB codes to engine. #18152

Merged
merged 32 commits into from
Feb 24, 2025
Merged

Add box2d JSB codes to engine. #18152

merged 32 commits into from
Feb 24, 2025

Conversation

tangkaikk
Copy link
Contributor

@tangkaikk tangkaikk commented Jan 10, 2025 •
edited
Loading

Re: #18090 ， All the infomation of comments and conversations is in the link of #18090.

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@tangkaikk tangkaikk mentioned this pull request Jan 10, 2025
Closed
6 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001794 bytes 1001794 bytes ✅ 0 bytes
2D All (legacy pipeline) 2408779 bytes 2408779 bytes ✅ 0 bytes
2D All (new pipeline) 2498268 bytes 2498268 bytes ✅ 0 bytes
(2D + 3D) All 5380494 bytes 5412998 bytes ⚠️ +32504 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16603945 bytes 16636449 bytes ⚠️ +32504 bytes

Interface Check Report

This pull request does not change any public interfaces !

@minggo
Copy link
Contributor

minggo commented Jan 10, 2025

Please fix eslint error.

@tangkaikk
Copy link
Contributor Author

Please fix eslint error.

It has been fixed.

@minggo minggo marked this pull request as draft January 22, 2025 06:47
@minggo
Copy link
Contributor

minggo commented Jan 22, 2025

Can not merge this PR now. Should wait editor to finish corresponding work.

@dumganhar dumganhar closed this Feb 13, 2025
@dumganhar dumganhar reopened this Feb 13, 2025
@dumganhar dumganhar marked this pull request as ready for review February 24, 2025 10:23
@dumganhar dumganhar merged commit b08a406 into cocos:v3.8.6 Feb 24, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minggo minggo minggo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tangkaikk @minggo @dumganhar