Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that ParticleSystem2D re-active causes particle could not be shown. #18295

Merged
merged 3 commits into from
Feb 8, 2025

Conversation

dumganhar
Copy link
Contributor

@dumganhar dumganhar commented Feb 7, 2025

Re: This issue is caused by the Pull Request #18052
I have described the reason in that PR.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested review from GengineJS and minggo February 7, 2025 13:26
Copy link

github-actions bot commented Feb 7, 2025

⚠️ Package size ⤴ 182 bytes, old: 5193082, new: 5193264

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -46230,8 +46230,9 @@
         onDestroy(): void;
         onFocusInEditor(): void;
         onLostFocusInEditor(): void;
         __preload(): void;
+        destroyRenderData(): void;
         protected _flushAssembler(): void;
         protected lateUpdate(dt: number): void;
         /**
          * @en Add a particle to the emitter.
@@ -68240,9 +68241,9 @@
             particles: _cocos_particle_2d_particle_simulator_2d__Particle[];
             active: boolean;
             uvFilled: number;
             finished: boolean;
-            renderData: MeshRenderData;
+            renderData: MeshRenderData | null;
             constructor(system: any);
             stop(): void;
             reset(): void;
             emitParticle(pos: any): void;

@dumganhar dumganhar requested a review from minggo February 8, 2025 03:29
@minggo minggo merged commit f94a17c into cocos:v3.8.6 Feb 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants