Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize code size for reflection-probe, particle, csm-layer, terrain. #18339

Merged

Conversation

dumganhar
Copy link
Contributor

Re: #18222

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo February 17, 2025 08:14
Copy link

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001884 bytes 1001794 bytes 👍 -90 bytes
2D All (legacy pipeline) 2408866 bytes 2408779 bytes 👍 -87 bytes
2D All (new pipeline) 2498355 bytes 2498268 bytes 👍 -87 bytes
(2D + 3D) All 5381005 bytes 5380494 bytes 👍 -511 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16604469 bytes 16603945 bytes 👍 -524 bytes

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL
ios PASS PASS FAIL
mac PASS PASS FAIL reflection-probe

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

@minggo minggo merged commit 0e3b6a5 into cocos:v3.8.6 Feb 18, 2025
13 checks passed
bofeng-song pushed a commit to bofeng-song/engine that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants