-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spine's crash due to destroy called after animation play complete. #18342
Conversation
@@ -83,6 +83,13 @@ void MiddlewareManager::update(float dt) { | |||
} | |||
|
|||
void MiddlewareManager::render(float dt) { | |||
for (auto &iter: _operateCacheMap) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node destroy maybe called while trigger update, but skeleton still exist at _updateList, thus skeletonAnimation will visit a destroyed object.
@cocos-robot run test cases |
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
@bofeng-song, Please check the result of
Task Details
|
@bofeng-song, Please check the result of
Task Details |
Merge for daily build. Probably we need to refactor the code later. |
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: