Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CI for Spine 3.8 + 4.2 again #18347

Closed
wants to merge 25 commits into from
Closed

Conversation

dumganhar
Copy link
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar marked this pull request as draft February 18, 2025 08:03
Copy link

github-actions bot commented Feb 18, 2025

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001794 bytes 1001794 bytes ✅ 0 bytes
2D All (legacy pipeline) 2408794 bytes 2408689 bytes 👍 -105 bytes
2D All (new pipeline) 2498283 bytes 2498178 bytes 👍 -105 bytes
(2D + 3D) All 5380509 bytes 5380395 bytes 👍 -114 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16603933 bytes 16895402 bytes ⚠️ +291469 bytes

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -51894,11 +51894,34 @@
                 timelines: Array<Timeline>;
                 apply(skeleton: Skeleton, lastTime: number, time: number, loop: boolean, events: Array<Event>, alpha: number, blend: MixBlend, direction: MixDirection): void;
                 hasTimeline(id: number): boolean;
             }
-            export interface Timeline {
+            export abstract class Timeline {
+                /**
+                 * @version 4.2
+                 */
+                frames: ArrayLike<number>;
                 apply(skeleton: Skeleton, lastTime: number, time: number, events: Array<Event>, alpha: number, blend: MixBlend, direction: MixDirection): void;
+                /**
+                 * @version 4.2
+                 */
+                getPropertyIds(): ArrayLike<number>;
+                /**
+                 * @version 3.8, deprecated in 4.2
+                 */
                 getPropertyId(): number;
+                /**
+                 * @version 4.2
+                 */
+                getFrameCount(): number;
+                /**
+                 * @version 4.2
+                 */
+                getFrameEntries(): number;
+                /**
+                 * @version 4.2
+                 */
+                getDuration(): number;
             }
             export enum MixBlend {
                 setup = 0,
                 first = 1,
@@ -51930,11 +51953,30 @@
                 static readonly LINEAR: number;
                 static readonly STEPPED: number;
                 static readonly BEZIER: number;
                 static readonly BEZIER_SIZE: number;
+                /**
+                 * @version 3.8, deprecated in 4.2
+                 */
                 abstract getPropertyId(): number;
                 constructor(frameCount: number);
                 getFrameCount(): number;
+                /**
+                 * @version 4.2
+                 */
+                frames: ArrayLike<number>;
+                /**
+                 * @version 4.2
+                 */
+                getPropertyIds(): ArrayLike<number>;
+                /**
+                 * @version 4.2
+                 */
+                getFrameEntries(): number;
+                /**
+                 * @version 4.2
+                 */
+                getDuration(): number;
                 setLinear(frameIndex: number): void;
                 setStepped(frameIndex: number): void;
                 getCurveType(frameIndex: number): number;
                 setCurve(frameIndex: number, cx1: number, cy1: number, cx2: number, cy2: number): void;
@@ -51946,18 +51988,30 @@
                 static PREV_TIME: number;
                 static PREV_ROTATION: number;
                 static ROTATION: number;
                 boneIndex: number;
+                /**
+                 * @version 3.8, deprecated in 4.2
+                 */
                 frames: ArrayLike<number>;
                 constructor(frameCount: number);
+                /**
+                 * @version 3.8, deprecated in 4.2
+                 */
                 getPropertyId(): number;
                 setFrame(frameIndex: number, time: number, degrees: number): void;
                 apply(skeleton: Skeleton, lastTime: number, time: number, events: Array<Event>, alpha: number, blend: MixBlend, direction: MixDirection): void;
             }
             export class TranslateTimeline extends CurveTimeline {
                 static readonly ENTRIES: number;
+                /**
+                 * @version 3.8, deprecated in 4.2
+                 */
                 frames: ArrayLike<number>;
                 constructor(frameCount: number);
+                /**
+                 * @version 3.8, deprecated in 4.2
+                 */
                 getPropertyId(): number;
                 setFrame(frameIndex: number, time: number, x: number, y: number): void;
                 apply(skeleton: Skeleton, lastTime: number, time: number, events: Array<Event>, alpha: number, blend: MixBlend, direction: MixDirection): void;
             }
@@ -51967,11 +52021,17 @@
                 apply(skeleton: Skeleton, lastTime: number, time: number, events: Array<Event>, alpha: number, blend: MixBlend, direction: MixDirection): void;
             }
             export class ShearTimeline extends TranslateTimeline {
                 constructor(frameCount: number);
+                /**
+                 * @version 3.8, deprecated in 4.2
+                 */
                 getPropertyId(): number;
                 apply(skeleton: Skeleton, lastTime: number, time: number, events: Array<Event>, alpha: number, blend: MixBlend, direction: MixDirection): void;
             }
+            /**
+             * @version 3.8, deprecated in 4.2
+             */
             export class ColorTimeline extends CurveTimeline {
                 static ENTRIES: number;
                 slotIndex: number;
                 frames: ArrayLike<number>;
@@ -51981,8 +52041,11 @@
                 setSlotIndex(inValue: number): void;
                 setFrame(frameIndex: number, time: number, r: number, g: number, b: number, a: number): void;
                 apply(skeleton: Skeleton, lastTime: number, time: number, events: Array<Event>, alpha: number, blend: MixBlend, direction: MixDirection): void;
             }
+            /**
+             * @version 3.8, deprecated in 4.2
+             */
             export class TwoColorTimeline extends CurveTimeline {
                 static readonly ENTRIES: number;
                 slotIndex: number;
                 frames: ArrayLike<number>;
@@ -51992,13 +52055,38 @@
                 setSlotIndex(inValue: number): void;
                 setFrame(frameIndex: number, time: number, r: number, g: number, b: number, a: number, r2: number, g2: number, b2: number): void;
                 apply(skeleton: Skeleton, lastTime: number, time: number, events: Array<Event>, alpha: number, blend: MixBlend, direction: MixDirection): void;
             }
+            /**
+             * @version 4.2
+             */
+            export class RGBATimeline extends CurveTimeline {
+                static ENTRIES: number;
+                slotIndex: number;
+                constructor(frameCount: number, bezierCount: number, slotIndex: number);
+                getSlotIndex(): number;
+                getPropertyId(): number;
+                setSlotIndex(inValue: number): void;
+                setFrame(frameIndex: number, time: number, r: number, g: number, b: number, a: number): void;
+                apply(skeleton: Skeleton, lastTime: number, time: number, events: Array<Event>, alpha: number, blend: MixBlend, direction: MixDirection): void;
+            }
             export class AttachmentTimeline implements Timeline {
                 slotIndex: number;
                 frames: ArrayLike<number>;
                 attachmentNames: Array<string>;
                 constructor(frameCount: number);
+                /**
+                 * @version 4.2
+                 */
+                getPropertyIds(): ArrayLike<number>;
+                /**
+                 * @version 4.2
+                 */
+                getFrameEntries(): number;
+                /**
+                 * @version 4.2
+                 */
+                getDuration(): number;
                 getPropertyId(): number;
                 getFrameCount(): number;
                 getSlotIndex(): number;
                 setSlotIndex(inValue: number): void;
@@ -52019,8 +52107,20 @@
             export class EventTimeline implements Timeline {
                 frames: ArrayLike<number>;
                 events: Array<Event>;
                 constructor(frameCount: number);
+                /**
+                 * @version 4.2
+                 */
+                getPropertyIds(): ArrayLike<number>;
+                /**
+                 * @version 4.2
+                 */
+                getFrameEntries(): number;
+                /**
+                 * @version 4.2
+                 */
+                getDuration(): number;
                 getPropertyId(): number;
                 getFrameCount(): number;
                 setFrame(frameIndex: number, event: Event): void;
                 apply(skeleton: Skeleton, lastTime: number, time: number, firedEvents: Array<Event>, alpha: number, blend: MixBlend, direction: MixDirection): void;
@@ -52028,8 +52128,20 @@
             export class DrawOrderTimeline implements Timeline {
                 frames: ArrayLike<number>;
                 drawOrders: Array<Array<number>>;
                 constructor(frameCount: number);
+                /**
+                 * @version 4.2
+                 */
+                getPropertyIds(): ArrayLike<number>;
+                /**
+                 * @version 4.2
+                 */
+                getFrameEntries(): number;
+                /**
+                 * @version 4.2
+                 */
+                getDuration(): number;
                 getPropertyId(): number;
                 getFrameCount(): number;
                 setFrame(frameIndex: number, time: number, drawOrder: Array<number>): void;
                 apply(skeleton: Skeleton, lastTime: number, time: number, firedEvents: Array<Event>, alpha: number, blend: MixBlend, direction: MixDirection): void;
@@ -52363,10 +52475,28 @@
                 rotateMode: RotateMode;
                 offsetRotation: number;
                 position: number;
                 spacing: number;
+                /**
+                 * @version 3.8, deprecated in 4.2
+                 */
                 rotateMix: number;
+                /**
+                 * @version 3.8, deprecated in 4.2
+                 */
                 translateMix: number;
+                /**
+                 * @version 4.2
+                 */
+                mixRotate: number;
+                /**
+                 * @version 4.2
+                 */
+                mixX: number;
+                /**
+                 * @version 4.2
+                 */
+                mixY: number;
                 constructor(name: string);
             }
             export enum PositionMode {
                 Fixed = 0,
@@ -52502,8 +52632,11 @@
                 audioPath: string;
                 findBone(boneName: string): BoneData;
                 findBoneIndex(boneName: string): number;
                 findSlot(slotName: string): SlotData;
+                /**
+                 * @version 3.8, deprecated in 4.2
+                 */
                 findSlotIndex(slotName: string): number;
                 findSkin(skinName: string): Skin;
                 findEvent(eventDataName: string): EventData;
                 findAnimation(animationName: string): Animation;
@@ -53592,8 +53725,9 @@
             protected _updateUseTint(): void;
             protected _updateBatch(): void;
             protected _updateDebugDraw(): void;
             /**
+             * @version 3.8, deprecated since spine 4.2
              * @en Sets vertex effect delegate.
              * @zh 设置顶点特效动画代理。
              * @param effectDelegate @en Vertex effect delegate. @zh 顶点特效代理。
              */
@@ -53882,8 +54016,10 @@
         /**
          * @internal Since v3.7.2 this is an engine private object.
          */
         export const simpleSpineAssembler: IAssemblerManager;
+        export function waitForSpineWasmInstantiation(): Promise<void>;
+        export const SPINE_VERSION = "3.8";
     }
     export class HeightField {
         data: Uint16Array;
         w: number;

@dumganhar dumganhar closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants