Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

解决 TiledLayer 组件 调整颜色无效的 bug. #18364

Open
wants to merge 4 commits into
base: v3.8.6
Choose a base branch
from

Conversation

finscn
Copy link
Contributor

@finscn finscn commented Feb 23, 2025

解决 TiledLayer 组件 调整颜色无效的 bug.

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@finscn
Copy link
Contributor Author

finscn commented Feb 23, 2025

此PR 可解决 #18363 .

Copy link

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001794 bytes 1001794 bytes ✅ 0 bytes
2D All (legacy pipeline) 2408779 bytes 2408760 bytes 👍 -19 bytes
2D All (new pipeline) 2498268 bytes 2498249 bytes 👍 -19 bytes
(2D + 3D) All 5380494 bytes 5380475 bytes 👍 -19 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16603945 bytes 16603926 bytes 👍 -19 bytes

Interface Check Report

This pull request does not change any public interfaces !

@@ -81,9 +81,7 @@ class Simple implements IAssembler {
}

createData (layer: TiledLayer): BaseRenderData {
if (JSB) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minggo 这个地方其实我不是太理解, 为什么 只在 JSB环境里执行 ensureAccessor() ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant