-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed #18374: 2D Node with MotionStreak and Rigidbody has wrong offset #18375
Merged
dumganhar
merged 1 commit into
cocos:v3.8.6
from
dumganhar:386-fix-motion-streak-rigidbody-offset
Feb 26, 2025
Merged
fixed #18374: 2D Node with MotionStreak and Rigidbody has wrong offset #18375
dumganhar
merged 1 commit into
cocos:v3.8.6
from
dumganhar:386-fix-motion-streak-rigidbody-offset
Feb 26, 2025
+58
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumganhar
commented
Feb 26, 2025
bool _isMeshBuffer{false}; | ||
uint8_t _isMeshBuffer: 1; | ||
uint8_t _isVertexPositionInWorld: 1; | ||
uint8_t _padding: 6; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add a new boolean property, we could reuse the byte
and make 8 bits for 8 boolean values.
@cocos-robot run test cases |
Code Size Check Report
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -61558,22 +61558,23 @@
constructor(nativeDrawInfo?: _cocos_2d_renderer_native_2d__NativeRenderDrawInfo);
get nativeObj(): _cocos_2d_renderer_native_2d__NativeRenderDrawInfo;
get render2dBuffer(): Float32Array | null;
clear(): void;
- setAccId(accId: any): void;
- setBufferId(bufferId: any): void;
- setAccAndBuffer(accId: any, bufferId: any): void;
- setVertexOffset(vertexOffset: any): void;
- setIndexOffset(indexOffset: any): void;
+ setAccId(accId: number): void;
+ setBufferId(bufferId: number): void;
+ setAccAndBuffer(accId: number, bufferId: number): void;
+ setVertexOffset(vertexOffset: number): void;
+ setIndexOffset(indexOffset: number): void;
setVB(vbBuffer: Float32Array): void;
setIB(ibBuffer: Uint16Array): void;
setVData(vDataBuffer: ArrayBufferLike): void;
setIData(iDataBuffer: ArrayBufferLike): void;
- setVBCount(vbCount: any): void;
- setIBCount(ibCount: any): void;
+ setVBCount(vbCount: number): void;
+ setIBCount(ibCount: number): void;
setVertDirty(val: boolean): void;
setDataHash(dataHash: number): void;
setIsMeshBuffer(isMeshBuffer: boolean): void;
+ setVertexPositionInWorld(isVertexPositionInWorld: boolean): void;
setMaterial(material: Material): void;
setTexture(texture: gfx.Texture | null): void;
setSampler(sampler: gfx.Sampler | null): void;
setModel(model: renderer.scene.Model): void;
|
qiuguohua
approved these changes
Feb 26, 2025
@dumganhar, Please check the result of
Task Details
|
@dumganhar, Please check the result of
Task Details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #18374
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: