Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default to case-insensitive Bus #74

Closed
wants to merge 1 commit into from
Closed

Revert default to case-insensitive Bus #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/cocotb_bus/bus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class Bus:
Support for ``struct``/``record`` ports where signals are member names.
"""

def __init__(self, entity, name, signals, optional_signals=[], bus_separator="_", case_insensitive=True, array_idx=None):
def __init__(self, entity, name, signals, optional_signals=[], bus_separator="_", case_insensitive=False, array_idx=None):
"""
Args:
entity (SimHandle): :class:`SimHandle` instance to the entity containing the bus.
Expand All @@ -47,7 +47,7 @@ def __init__(self, entity, name, signals, optional_signals=[], bus_separator="_"
bus_separator (str, optional): Character(s) to use as separator between bus
name and signal name. Defaults to '_'.
case_insensitive (bool, optional): Perform case-insensitive match on signal names.
Defaults to True.
Defaults to False.
array_idx (int or None, optional): Optional index when signal is an array.
"""
self._entity = entity
Expand Down Expand Up @@ -81,7 +81,7 @@ def _caseInsensGetattr(self, obj, attr):
return getattr(obj, a)
return None

def _add_signal(self, attr_name, signame, array_idx=None, case_insensitive=True):
def _add_signal(self, attr_name, signame, array_idx=None, case_insensitive=False):
self._entity._log.debug("Signal name {}, idx {}".format(signame, array_idx))
if case_insensitive:
handle = self._caseInsensGetattr(self._entity, signame)
Expand Down
Loading